Skip to content

Disable output to console in non-development environment #43

Closed
innomaxx opened this issue Oct 2, 2019 · 2 comments
Closed

Disable output to console in non-development environment #43

innomaxx opened this issue Oct 2, 2019 · 2 comments

Comments

@innomaxx
Copy link
Contributor

innomaxx commented Oct 2, 2019

Here is my fake code.

image

In production environment it still writes to console, which is unacceptable for me.

image

In package's source code there are no runtime environment checks present.

image

Can you provide some process.env.DEBUG or process.env.NODE_ENV checks?

@dalisoft
Copy link
Member

dalisoft commented Oct 2, 2019

Hi dear friend.

I am sorry, because such of error or mismatching your exception about project (because of my fail).

I currently does not have as i work on full-time job. I don’t think for me nothing bad is from logging just start with ms and address, but as you know, each peoples mind differs from other.

Maybe, can you submit PR if possible. Sorry again.

Thanks for using this library and wish you all the best

@innomaxx
Copy link
Contributor Author

innomaxx commented Oct 3, 2019

Already submitted PR, please check

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants