Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public ID hash API #1740

Closed
gdamore opened this issue Dec 25, 2023 · 0 comments
Closed

Public ID hash API #1740

gdamore opened this issue Dec 25, 2023 · 0 comments

Comments

@gdamore
Copy link
Contributor

gdamore commented Dec 25, 2023

The nni_idhash API is used internally and is super useful there. In the past I've been asked about exposing this, and been hesitant to do so, as I really didn't want to see NNG become a general utility library.

However, more and more people are looking to it for just such a need -- using it to solve their portability problems.

It seems to me that this API is sufficiently useful that it could be exposed under a supplemental API, like I have done for other supplemental APIs.

One thing we might want to look at is whether to also provide a 64-bit ID based variant, as that has been requested in some cases as well. (We used to have one, but I removed it as NNG itself only uses 32-bit IDs at the core. Extending to support 64-bit IDs is relatively straightforward.)

@gdamore gdamore changed the title Consider exposing the ID hash API Public ID hash API Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant