Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ninja install" step missing from Quick Start in README #723

Closed
lobocv opened this issue Sep 13, 2018 · 1 comment
Closed

"ninja install" step missing from Quick Start in README #723

lobocv opened this issue Sep 13, 2018 · 1 comment
Labels
docs
Milestone
v1.1

Comments

@lobocv
Copy link

lobocv commented Sep 13, 2018

Hi,

For those unfamiliar with the Ninja build system it would be nice if you put the "ninja install" step after the step "ninja test".
I was scratching my head for a few minutes trying to figure out how to install and then I just tried "ninja install" and it worked.

Sorry if this sounds stupid, I just think it would be a bit more clear.
@gdamore
Copy link
Contributor

gdamore commented Sep 13, 2018

Fair enough! I'll fix it.

@gdamore gdamore added the docs label Sep 13, 2018
@gdamore gdamore added this to the v1.1 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@gdamore @lobocv