Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the logic in encode_basic_field() #243

Closed
PetteriAimonen opened this issue Feb 12, 2017 · 1 comment
Closed

Clean up the logic in encode_basic_field() #243

PetteriAimonen opened this issue Feb 12, 2017 · 1 comment
Labels
Component-Encoder FixedInGit Priority-Low Type-Review

Comments

@PetteriAimonen
Copy link
Member

The implicit_has logic in encode_basic_field() is quite tricky. Proto3 fields with pointer types seem to work more by luck than by design, so some cleanup should probably be done.
@PetteriAimonen
Copy link
Member Author

It has now been cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Encoder FixedInGit Priority-Low Type-Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PetteriAimonen