Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout is not adjusted immediately anymore when resizing the browser window #266

Closed
lxb301 opened this issue Jul 3, 2020 · 2 comments
Closed

Comments

@lxb301
Copy link

lxb301 commented Jul 3, 2020

Describe the bug
Gallery layout/size is not adjusted immediately anymore when resizing the browser window or rotating the smartphone.

Expected behavior
With nanogallery 2.4.2 the layout and thumbnail sizes for Mosaic and Cascading layouts were automatically adjusted while the window was being resized.
Nanogallery 3.0.1 does not do this anymore. The layout stays and pictures gets cropped (cf. screenshot) until one moves a scrollbar. Then the layout change is triggered and everything looks as it should.

I have added two JSfiddles an a screenshot to illustrate this:
Made with 3.0.1: https://jsfiddle.net/kfznvLyj/
Made with 2.4.2: https://jsfiddle.net/ujec5bqL/
Examples are made with

resize

A similar behaviour can be observed when viewing the page on a smartphone and the display is rotated.
=> 2.4.2 automatic adjustment of layout as soon as screen is rotated
=> 3.0.1 no adjustment of layout until scrolling up or down

Tested:
Cascasing and Mosaic layouts
Win10: Firefox, Chrome, Edge
Android: Firefox

Any help is very much appreciated.

Cheers,
Alex

@Kris-B
Copy link
Member

Kris-B commented Jul 3, 2020

@lxb301 thanks for the detailed issue description.
I pushed a new version to the DEV branch. Can you please check?
https://github.com/nanostudio-org/nanogallery2/tree/dev

@lxb301
Copy link
Author

lxb301 commented Jul 3, 2020

Hi Kris-B,

Thanks for the quick response. I did a brief test and the issue seems to be solved in the new version.

All the best and thanks for this amazing piece of software!!
Alex

@lxb301 lxb301 closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants