Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .python-version #158

Closed
FichteFoll opened this issue Jul 10, 2020 · 6 comments
Closed

Remove .python-version #158

FichteFoll opened this issue Jul 10, 2020 · 6 comments

Comments

@FichteFoll
Copy link

FichteFoll commented Jul 10, 2020

On ST4 builds, the plugin is ignored entirely because the .python-version file is interpreted and only supports 3.3 and 3.8 for the two available runtimes in that version. The exact exception is as follows:

ignoring plugins in package MarkdownTOC, version file Packages/MarkdownTOC/.python-version contains an invalid version: 3.7.1\x0a

The file was added in f97f221, but I don't see a particular reason for it.

@naokazuterada
Copy link
Owner

naokazuterada commented Jul 12, 2020

Thank you for reporting!

This file is for code style. So I'd like to keep the version number.
I want to know a specific version that works in ST4 environment and also works fine for "black".
Will it work if I set it to 3.8.3? If you tell me the version that works, I will change it to that value. Or could you create a PR with the changed version ?

@FichteFoll
Copy link
Author

I know that 3.8 works, if that's fine for you. The version ST4 bundles is 3.8.3 currently and will likely increase, but I don't see much of a point in pinning the patch version since that will likely be updated in the future.

@naokazuterada
Copy link
Owner

@FichteFoll @nickhstr please check working correctly.

@FichteFoll
Copy link
Author

Should work like that.

@nickhstr
Copy link
Contributor

@naokazuterada thanks for the quick turn-around time on merging the PR! It seems to have done the trick in ST4.
Looking forward to its release on Package Control.

@naokazuterada
Copy link
Owner

Thank you for all!

Released 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants