Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the header search path for react-native in release scheme. #7

Closed
chirag04 opened this issue Jul 1, 2015 · 7 comments
Closed

fix the header search path for react-native in release scheme. #7

chirag04 opened this issue Jul 1, 2015 · 7 comments
Labels

Comments

@chirag04
Copy link
Contributor

chirag04 commented Jul 1, 2015

Right now header search path for react-native in release scheme is $(SRCROOT)/../../React.

It should just be $(SRCROOT)/../react-native/React ??

@naoufal

@naoufal
Copy link
Owner

naoufal commented Jul 2, 2015

That's right it should be.

The package.json should also be updated to list react-native as a peerDependency for this to be accurate.

Currently, react-native is being installed as a dependency of this package and so the path would be need to $(SRCROOT)/node_modules/react-native/React.

@naoufal naoufal added the bug label Jul 2, 2015
@chirag04
Copy link
Contributor Author

chirag04 commented Jul 2, 2015

yeah. def. need peerDependency and then update the release/debug paths. Let me know if you need help here. I can PR.

@naoufal naoufal mentioned this issue Jul 3, 2015
@naoufal
Copy link
Owner

naoufal commented Jul 3, 2015

@chirag04 Submitted a PR #8. Can you review?

@chirag04
Copy link
Contributor Author

chirag04 commented Jul 4, 2015

LGTM.

@naoufal naoufal closed this as completed in #8 Jul 4, 2015
@chirag04
Copy link
Contributor Author

chirag04 commented Jul 4, 2015

Thanks. Looking forward to a version bump.

@chirag04
Copy link
Contributor Author

@naoufal can you publish this to npm?

@naoufal
Copy link
Owner

naoufal commented Jul 17, 2015

Thanks for the reminder @chirag04. Published! https://www.npmjs.com/package/react-native-activity-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants