Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canMakePayments vs canMakePayment #40

Open
miracle2k opened this issue Nov 3, 2017 · 4 comments
Open

canMakePayments vs canMakePayment #40

miracle2k opened this issue Nov 3, 2017 · 4 comments
Labels
enhancement

Comments

@miracle2k
Copy link
Contributor

It seems the PaymentRequest standard uses canMakePayment, but this library uses canMakePayments. Any change we can align this?
@naoufal
Copy link
Owner

naoufal commented Nov 4, 2017

@miracle2k Absolutely! Would you be up for submitting a PR with this change?

@miracle2k
Copy link
Contributor Author

I will.

@horacioh
Copy link

@miracle2k are you up into this? If I understand this is to change the method name to canMakePayment in the React Native side right?

cc @naoufal

@Andreyco
Copy link
Collaborator

Andreyco commented Jun 6, 2018

Working on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miracle2k @horacioh @Andreyco @naoufal