Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on React-Core, not React #123

Open
neilkimmett opened this issue Jul 15, 2021 · 1 comment
Open

Depend on React-Core, not React #123

neilkimmett opened this issue Jul 15, 2021 · 1 comment

Comments

@neilkimmett
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-native-safari-view@2.1.0 for the project I'm working on.

In newer versions of React Native you need to depend on React-Core, not React

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-safari-view/react-native-safari-view.podspec b/node_modules/react-native-safari-view/react-native-safari-view.podspec
index 45630b1..a5fc4f4 100644
--- a/node_modules/react-native-safari-view/react-native-safari-view.podspec
+++ b/node_modules/react-native-safari-view/react-native-safari-view.podspec
@@ -9,7 +9,7 @@ Pod::Spec.new do |s|
   s.homepage     = 'https://github.com/naoufal/react-native-safari-view'
   s.source       = { :git => "https://github.com/naoufal/react-native-safari-view.git" }
   s.platform     = :ios, "7.0"
-  s.dependency 'React'
+  s.dependency 'React-Core'
   s.source_files     = "*.{h,m}"
   s.preserve_paths   = "*.js"
 end

This issue body was partially generated by patch-package.

@buschco
Copy link

buschco commented Sep 17, 2023

You are right. Took me a while to find evidence for this change:

facebook/react-native#29633 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants