Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface speed is returned as a float instead of an integer, which conflicts with the documentation. #1801

Open
1 task done
Punicaa opened this issue Nov 21, 2022 · 3 comments

Comments

@Punicaa
Copy link

Punicaa commented Nov 21, 2022

Description of Issue/Question

Speed is returned as a float where according to the manual it should be an integer, this appears to be vendor independent as it happens on Juniper and Arista:

# napalm --user <user>--vendor eos <device> call get_interfaces
Enter password:
{
    "Ethernet8": {
        "is_up": false,
        "is_enabled": true,
        "description": "",
        "last_flapped": 1663056216.0141013,
        "mtu": 10178,
        "speed": 10000.0,
        "mac_address": "28:99:3A:41:E3:A7"
    },

Did you follow the steps from https://github.com/napalm-automation/napalm#faq

(Place an x between the square brackets where applicable)

  • Yes
  • [] No

Setup

napalm version

(Paste verbatim output from pip freeze | grep napalm between quotes below)

napalm==4.0.0

Network operating system version

(Paste verbatim output from show version - or equivalent - between quotes below)

EOS 4.23.0.1F

Steps to Reproduce the Issue

napalm --user <user> --vendor eos <device> call get_interfaces

Error Traceback

(Paste the complete traceback of the exception between quotes below)

N/A
@network-shark
Copy link
Contributor

@Punicaa See #1478

And I thought it was fixed by #1650

But the documentation is still wrong @ktbyers any idea why

https://napalm.readthedocs.io/en/latest/base.htmlhighlight=get_interfaces#napalm.base.base.NetworkDriver.get_interfaces

is not updated ?

@Punicaa
Copy link
Author

Punicaa commented Nov 28, 2022

Thanks. Should we leave this open until the docs have been updated?

@Punicaa Punicaa changed the title Interface speed is returned as a float instead of an integer Interface speed is returned as a float instead of an integer, which conflicts with the documentation. Nov 28, 2022
@M0NsTeRRR
Copy link
Contributor

Hello @network-shark @Punicaa,

You need to use "develop" documentation not "latest" as my fix was merged into develop branch.
https://napalm.readthedocs.io/en/develop/

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants