Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In QtViewerButtons, store references to pop in class instances #6793

Open
andy-sweet opened this issue Mar 29, 2024 · 0 comments
Open

In QtViewerButtons, store references to pop in class instances #6793

andy-sweet opened this issue Mar 29, 2024 · 0 comments

Comments

@andy-sweet
Copy link
Member

andy-sweet commented Mar 29, 2024 •
edited

I will feel more comfortable if we will store references to pop in class instances. Otherwise GC may clean it to early.

Originally posted by @Czaki in #5986 (comment)

For example, the roll popup here:

napari/napari/_qt/widgets/qt_viewer_buttons.py

Line 215 in 3f2e58a

pop = QtPopup(self)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy-sweet