Enh: added strict object name conflict policy #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geektophe
force-pushed
the
enh_strict_object_coflict_policy
branch
4 times, most recently
from
8835ec9
to
74e9f0e
Compare
This patch adds a global parameter named `conflict_policy` to control the shinken behavior when there's name conflict between objects. When more than one object are created with the same name and no definition order has been specified, the default behavior is to raise a warning message and keep the last definition. When enabling strict conflict naming policy by setting the global parameter `conflict_policy` to `strict`, this results in an error that prevents the configuration from being loaded. This is typically used to enforce more precise objects definition, and avoid silent collisions lading to unexpected behavior.
geektophe
force-pushed
the
enh_strict_object_coflict_policy
branch
from
74e9f0e
to
d680640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a global parameter named
conflict_policyto control the shinken behavior when there's name conflict between objects.When more than one object are created with the same name and no definition order has been specified, the default behavior is to raise a warning message and keep the last definition.
When enabling strict conflict naming policy by setting the global parameter
conflict_policytostrict, this results in an error that prevents the configuration from being loaded.This is typically used to enforce more precise objects definition, and avoid silent collisions lading to unexpected behavior.