You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any time I run napi build, the bindgen JavaScript file & .d.ts file should generate
Current Results:
If my rust code hasn't changed since a previous run of napi build, I delete all generated assets, and run napi build again, only the .node file is generated.
Upon further inspection, it appears that this is caused by the following code:
Expected Results:
napi build
, the bindgen JavaScript file & .d.ts file should generateCurrent Results:
napi build
, I delete all generated assets, and runnapi build
again, only the.node
file is generated.Upon further inspection, it appears that this is caused by the following code:
napi-rs/cli/src/build.ts
Lines 605 to 609 in 853f52e
Where
idents
is only populated on file change and:napi-rs/cli/src/build.ts
Lines 816 to 822 in 853f52e
Where the ident check occurs.
I think we need to be calculating all idents each run, and not just changed.
The text was updated successfully, but these errors were encountered: