Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env::from_raw should be unsafe #310

Closed
adumbidiot opened this issue Nov 19, 2020 · 2 comments
Closed

Env::from_raw should be unsafe #310

adumbidiot opened this issue Nov 19, 2020 · 2 comments

Comments

@adumbidiot
Copy link
Collaborator

Env::from_raw(env: sys::napi_env) takes a pointer that may or may not be valid.
@Brooooooklyn
Copy link
Sponsor Member

Seems like Env::from_raw is already unsafe in master branch

@adumbidiot
Copy link
Collaborator Author

Oops, guess my fork is old. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Brooooooklyn @adumbidiot