Support config content in lint and webpack #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prantlf
force-pushed
the
lint-config
branch
from
05ff8f5
to
591053b
Compare
prantlf
changed the title
While enableAllRules serves as "tags": ["recommended"], there is no way to specify the whole config as known from .denolint.json. Passing RulesConfig would be better, but it would need to make it serialisable.
prantlf
force-pushed
the
lint-config
branch
from
591053b
to
2eb110b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
enableAllRulesserves as"tags": ["recommended"], there is no way to specify the whole config as known from.denolint.json. PassingRulesConfigwould be better, but it would need to make it serialisable.This is an alternative to #643. A draft, because not passing a string instead of an object is clumsy.