Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsegments' request urls do not contain ports anymore #323

Open
MarcMogdanz opened this issue Jan 12, 2022 · 0 comments
Open

Subsegments' request urls do not contain ports anymore #323

MarcMogdanz opened this issue Jan 12, 2022 · 0 comments

Comments

@MarcMogdanz
Copy link
Contributor

MarcMogdanz commented Jan 12, 2022

This commit in the AWS XRay SDK (introduced in version 3.3.4) changed how the returned request url gets queried and now it does not contain ports anymore.

I've implemented a fix in our test suite by making the port in the regex optional. We should keep an eye out if this results in any problems.

-/^http:\/\/127.0.0.1:[0-9]{1,5}\/example-endpoint/
+/^http:\/\/127.0.0.1(:[0-9]{1,5})?\/example-endpoint/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant