Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] UI(Thread): Improve Display for multi-images #58

Closed
mathiasayivor opened this issue Oct 3, 2022 · 11 comments · Fixed by #126
Closed

[FEATURE] UI(Thread): Improve Display for multi-images #58

mathiasayivor opened this issue Oct 3, 2022 · 11 comments · Fixed by #126

Comments

@mathiasayivor
Copy link
Contributor

Description

Currently, uploaded images are being displayed in grid form, but need some improvement (i.e too much gap for images with different heights)

We have a few options:

  1. Use masonry style to display the upload's images on large devices but create a slider (aka carousel) on small devices
  2. Carousel for both small and large devices

Screenshots

No response

Additional information

No response

@Akshat2403
Copy link

can you assign me this issue?

@narayan954
Copy link
Owner

can you assign me this issue?

Sure, go ahead and please confirm the program

@Akshat2403 Akshat2403 removed their assignment Dec 10, 2022
@kshitij01042002
Copy link
Contributor

@narayan954 I can work on this..

@TheCharismaticEnigma
Copy link

@narayan954 Hey! I'd like to work on this issue too . Even though I'm just a beginner, rolling and bouncing around like a turd in the wind trying to get used to the workflow, I'd love to add something of value and if you like my changes, you can merge them. I'd like to work on other issues too. Doesn't matter if you merge them or not. I'd just like to contribute to this project as much as possible.

@TheCharismaticEnigma
Copy link

TheCharismaticEnigma commented Dec 13, 2022

@narayan954 I know HTML AND CSS and I'm learning JS right now. So I'll take anything that you throw and I'd be able to handle.

@narayan954
Copy link
Owner

@narayan954 Hey! I'd like to work on this issue too . Even though I'm just a beginner, rolling and bouncing around like a turd in the wind trying to get used to the workflow, I'd love to add something of value and if you like my changes, you can merge them. I'd like to work on other issues too. Doesn't matter if you merge them or not. I'd just like to contribute to this project as much as possible.

Hi @TheCharismaticEnigma thanks a lot for showing such enthusiasm :) , I'd love to have you as a contributor ,but currently this issue is already assigned to @kshitij01042002 ,you may ask him or wait and see if the issue is unattended for 3 days ,you can claim it. Till then feel free to checkout other issues ,report some issue you find and help the open source grow. :)

Regards

@kshitij01042002
Copy link
Contributor

@TheCharismaticEnigma I have already raised a PR for this one.
You can run the project locally and find some bugs and raise a PR if you want

@narayan954 narayan954 linked a pull request Dec 14, 2022 that will close this issue
@narayan954
Copy link
Owner

@narayan954 I know HTML AND CSS and I'm learning JS right now. So I'll take anything that you throw and I'd be able to handle.

You can try improving UI components :)

@TheCharismaticEnigma
Copy link

@narayan954 I'll run the project locally and try to find something that I can improve. Cheers :)
@narayan954 Do you have any suggestions regarding the improvements in the UI? Any section or component(s) that need(s) any improvements ?

@TheCharismaticEnigma
Copy link

TheCharismaticEnigma commented Dec 14, 2022

@kshitij01042002 @narayan954
Hey man. I'm trying to run this on my local machine but I'm not able to break through. I tried to use git bash
to open it but I'm not getting anything. I read the README file and followed the steps but got nowhere. Is there any way that I can run this on my local server? I'd be glad if you could help me out.

@narayan954
Copy link
Owner

@kshitij01042002 @narayan954
Hey man. I'm trying to run this on my local machine but I'm not able to break through. I tried to use git bash
to open it but I'm not getting anything. I read the README file and followed the steps but got nowhere. Is there any way that I can run this on my local server? I'd be glad if you could help me out.

@TheCharismaticEnigma Hi, please ask in the communication channel or create a discussion for this and share problems you're facing.
Ps: Don't message in other's issues , it makes no sense to the issue and unnecessary pings to other people engaged in this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants