Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification #701

Closed
Deepanshu0703 opened this issue Jul 7, 2023 · 4 comments · Fixed by #705
Closed

Email verification #701

Deepanshu0703 opened this issue Jul 7, 2023 · 4 comments · Fixed by #705

Comments

@Deepanshu0703
Copy link
Contributor

Description

There is only @gmail.com is allowed in mail but there are more othe mail id domain so i thing that should be improved.

Steps to reproduce

removing only matching gmail.com and checking all domain type mail id.

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

@fiskryeziu
Copy link
Contributor

why not use something more general regex like

/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i;

@narayan954
Copy link
Owner

why not use something more general regex like

/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i;

exactly, it involves just changing this regex

@Deepanshu0703
Copy link
Contributor Author

So that is a bug that is why I raised the issue .

@narayan954
Copy link
Owner

So that is a bug that is why I raised the issue .

right, you can work on this! and do test your regex! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants