Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not rely on <style scoped="true"> #8

Open
drzraf opened this issue Aug 25, 2022 · 1 comment
Open

do not rely on <style scoped="true"> #8

drzraf opened this issue Aug 25, 2022 · 1 comment

Comments

@drzraf
Copy link
Contributor

drzraf commented Aug 25, 2022

The currently generated markup looks like:

<div class="wp-block-cp-timeline-content-timeline-block Cool-Content-Timeline">
<div class="cool-timeline-block-b238fb3a-989b-4379-8fae-61af5ad138f2">
<style scoped="true">
.cool-timeline-block-b238fb3a-989b-4379-8fae-61af5ad138f2 .cool-vertical-timeline-body .story-time p{color: #333;}
 ... [lot of CSS] ...
</style>
<div class="cool-vertical-timeline-body both-sided left">
<div class="cool-timeline-block-list">...

But any change to the style.scss (like one that recently introduced linear-gradient(to bottom, rgba(230, 230, 230, 0) 0%, #D91B3E 10%) break the generated markup identity.

While such a thing is something difficult to avoid, inlining the CSS is calling for problems and should rather not be done.

@drzraf
Copy link
Contributor Author

drzraf commented Oct 31, 2022

I think having a Github red tag "forward-compatibility" would be important to keep track of issues/change that intend to avoid future block breakages.

@drzraf drzraf mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant