Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include current environment variables for child processess #6

Closed
narirou opened this issue Nov 11, 2014 · 3 comments
Closed

Include current environment variables for child processess #6

narirou opened this issue Nov 11, 2014 · 3 comments

Comments

@narirou
Copy link
Owner

narirou commented Nov 11, 2014

#5 (Reported by @vkareh)

@vkareh
Copy link
Contributor

vkareh commented Nov 11, 2014

How is this different from #5? Do you feel the _.extend() should happen inside app.listen?

@vkareh
Copy link
Contributor

vkareh commented Nov 11, 2014

The problem with adding environment variables inside a function is that it forces them to be extended during runtime, rather than during the start of the app, thus possibly preventing the app itself from overriding any environment variables it needs for its child processes. This could lead to unpredictable conditions within the node app being developed with gulp.

The _.extend() should happen outside of the scope of any function so that it represents the actual environment variables of the system.

@narirou
Copy link
Owner Author

narirou commented Nov 11, 2014

I thought it is convenient to extend values inside of the function,
but you are right, environment variables might be unpredictable as you say.
I will re-open & merge your pull-request, and add more test codes.
Thanks.

@narirou narirou closed this as completed Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants