fix(Modal): limit height of modal, and allow for vertical scroll #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agreatscott
force-pushed
the
make-modal-scrollable
branch
from
112476d
to
7a064c0
Compare
agreatscott
commented
Oct 19, 2021
Comment on lines
+14
to
+15
| overflow: scroll; | ||
| max-height: 80vh; |
There was a problem hiding this comment.
These two lines should be all that's new in this file.
akdetrick
approved these changes
Oct 19, 2021
agreatscott
force-pushed
the
make-modal-scrollable
branch
from
7a064c0
to
3f3aa5d
Compare
akdetrick
pushed a commit
that referenced
this pull request
Oct 19, 2021
### [1.2.1](v1.2.0...v1.2.1) (2021-10-19) ### Bug Fixes * **Modal:** limit height of modal, and allow for vertical scroll ([#250](#250)) ([eb37832](eb37832))
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #249
An ugly diff because of the initial prettier run, but the important changes are to the Modal code itself and the addition of the ScrollableModal story.
Not yet quite what design communicated to us verbally as their dream state, but this is an easy stopgap to put us in the realm of what's acceptable and usable.