Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supporting of primitive arrays #10

Closed
MaksHladki opened this issue Feb 5, 2020 · 2 comments
Closed

Add supporting of primitive arrays #10

MaksHladki opened this issue Feb 5, 2020 · 2 comments
Labels
enhancement New feature or request released

Comments

@MaksHladki
Copy link

Hi. I found an issue when the model uses an array with primitive types as a property.
I used your example for testing.
Please update User* models to use string array instead of the Address one.

export class User {
  firstName!: string;
  lastName!: string;
  profile!: Profile;
  addresses!: string[];
}

export class UserVm {
  first!: string;
  last!: string;
  full!: string;
  profile!: ProfileVm;
  addresses!: string[];
}

export class UserVm {
  first!: string;
  last!: string;
  full!: string;
  profile!: ProfileVm;
  addresses!: string[];
}

Then try to build the app, you will see an exception TypeError: Cannot read property 'transformFlags' of undefined.
I hope it wouldn't be very difficult to fix.

@nartc
Copy link
Owner

nartc commented Feb 5, 2020

Oh man this is embarassing xD. Yeah, it wouldn’t be difficult to fix but idk why I didn’t really think of all the cases. Do you mind submit a PR (even just a markdown file) to list all the cases you could think of?

@nartc nartc added the enhancement New feature or request label Feb 5, 2020
@nartc nartc closed this as completed in 6fb95ee Feb 5, 2020
@nartc
Copy link
Owner

nartc commented Feb 5, 2020

🎉 This issue has been resolved in version 1.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nartc nartc added the released label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants