Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): bump nestjs dependencies to v10 #561

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

timonmasberg
Copy link
Contributor

@timonmasberg timonmasberg commented Jun 28, 2023

Since NestJS has released version 10, we must adapt the peer dependencies to avoid issues when installing the @automapper/nestjs package with NestJS v10 packages.

NestJS Release Notes: https://github.com/nestjs/nest/releases/tag/v10.0.0, no effects for this package (besides the es2021 target as default target).

Fixes #560

@timonmasberg timonmasberg marked this pull request as ready for review June 28, 2023 12:44
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PaprikaBoyTheOneAndOnly
Copy link

Any updates on this?

@timonmasberg
Copy link
Contributor Author

timonmasberg commented Jul 7, 2023

Any updates on this?

Until it is merged you could use @timonmasberg/automapper-nestjs

@praju-aot
Copy link

Hi @nartc,

Could you please comment if there is going to be an official release soon?

@mmick66
Copy link

mmick66 commented Aug 4, 2023

Please! The people need it!!

@notmedia
Copy link

@nartc Hey, could you merge this PR?

@hkaraoglu
Copy link

hkaraoglu commented Sep 1, 2023

Hey @nartc, why these checks could not have completed? Is there anything that we can do to complete checks?

@hkaraoglu
Copy link

hkaraoglu commented Sep 6, 2023

Anybody can use this package for workaround. It is a package that merged version of this pr.

npm i @timonmasberg/automapper-nestjs --save

Ref:
https://socket.dev/npm/package/@timonmasberg/automapper-nestjs

@MichaelCastiau
Copy link

Is there any update on this? Nx 16 has also be released with NestJs 10...

@Choleriker
Copy link

A half a year later and its still not merged. Is it rocket science? :)

@notmedia
Copy link

notmedia commented Jan 7, 2024

@nartc Hi! Please merge this PR

@wilfriedago
Copy link

Hi! @nartc Can you merge this PR, ASAP ! We badly need it !😭

@dtap001
Copy link
Contributor

dtap001 commented Jan 22, 2024

ANY UPDATE??? WE NEED THIS!!!!

@dtap001
Copy link
Contributor

dtap001 commented Jan 22, 2024

@timonmasberg is there any chance you publish this package by yourself?

@timonmasberg
Copy link
Contributor Author

@timonmasberg is there any chance you publish this package by yourself?

as mentioned above:

Any updates on this?

Until it is merged you could use @timonmasberg/automapper-nestjs

@dtap001
Copy link
Contributor

dtap001 commented Jan 22, 2024

Thanks!

@nartc
Copy link
Owner

nartc commented Jan 22, 2024

Sorry for the super late update.

@nartc nartc merged commit 1403b41 into nartc:main Jan 22, 2024
2 checks passed
@nartc
Copy link
Owner

nartc commented Jan 22, 2024

v8.8.0 has been released with this PR's changes. Once again, thanks @timonmasberg for the PR. And apologies to everyone else for the late response.

v8.8.0 has been released immediately with this change. I'll get to some other PRs and release another minor version as needed.

@notmedia
Copy link

@nartc Thank you! The same problem in mikro-orm plugin

nartc pushed a commit to jersmart/automapper-typescript that referenced this pull request Jan 22, 2024
* feat(nestjs): bump nestjs dependencies to v10

* feat(nestjs): target es2021
@nartc
Copy link
Owner

nartc commented Jan 22, 2024

@notmedia I need to keep up-to-date with mikro breaking changes first. Unless you can submit a PR real quick?

@notmedia
Copy link

@nartc Unfortunately I didn't work on it. I could look on the next week and let you know.

@nartc
Copy link
Owner

nartc commented Jan 22, 2024

It's alright. I've scheduled some time to get the repo as up-to-date as possible. Thanks again for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nestjs v10 dependency issues