Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-injection-token): better decide when to use factory or provided value (#161) #162

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

diegovilar
Copy link
Contributor

This PR fixes #161

@nartc
Copy link
Collaborator

nartc commented Nov 19, 2023

@all-contributors please add @diegovilar for code

Copy link
Contributor

@nartc

I've put up a pull request to add @diegovilar! 🎉

Copy link

nx-cloud bot commented Nov 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 056b84c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@nartc nartc merged commit 61d496d into ngxtension:main Nov 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createInjectionToken wrongfully disregards falsy argument passed to generated provider function
2 participants