Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add if-validator #40

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Conversation

develite98
Copy link
Contributor

Hi, ifValidator or ifAsyncValidator are simple utility functions for help to simplify change dynamically validation of Angular Reactive Form.

Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits.

Can you add some tests (either unit tests or e2e tests using the test-app)?

docs/src/content/docs/utilities/if-validator.md Outdated Show resolved Hide resolved
libs/ngxtension/if-validator/project.json Outdated Show resolved Hide resolved
libs/ngxtension/if-validator/src/if-validator.ts Outdated Show resolved Hide resolved
@develite98
Copy link
Contributor Author

A couple of nits.

Can you add some tests (either unit tests or e2e tests using the test-app)?

Hello, @nartc I've already fixed comments and added e2e testing, but as I'm not experienced with it (e2e), could you help me check it?

Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good enough

@nartc
Copy link
Collaborator

nartc commented Sep 14, 2023

@all-contributors please add @develite98 for code

@nx-cloud
Copy link

nx-cloud bot commented Sep 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d7424e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@allcontributors
Copy link
Contributor

@nartc

I've put up a pull request to add @develite98! 🎉

@nartc nartc merged commit 7e6cf2e into ngxtension:main Sep 15, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants