-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add if-validator #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits.
Can you add some tests (either unit tests or e2e tests using the test-app
)?
Hello, @nartc I've already fixed comments and added e2e testing, but as I'm not experienced with it (e2e), could you help me check it? |
Co-authored-by: Chau Tran <nartc7789@gmail.com>
Co-authored-by: Chau Tran <nartc7789@gmail.com>
26ec0a0
to
2d7424e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good enough
@all-contributors please add @develite98 for code |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2d7424e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
I've put up a pull request to add @develite98! 🎉 |
Hi,
ifValidator
orifAsyncValidator
are simple utility functions for help to simplify change dynamically validation of Angular Reactive Form.