Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(computed-from): added computed from #11

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

eneajaho
Copy link
Collaborator

@eneajaho eneajaho commented Sep 10, 2023

closes #2

  • added computedFrom utility fn (with ability to pass an injector)
  • tests for multiple cases

@nx-cloud
Copy link

nx-cloud bot commented Sep 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9f97b5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@nartc
Copy link
Collaborator

nartc commented Sep 10, 2023

@all-contributors please add @eneajaho for code

@allcontributors
Copy link
Contributor

@nartc

I've put up a pull request to add @eneajaho! 🎉

@nartc nartc force-pushed the feat/computed-from-wip branch 2 times, most recently from 22929e1 to 07b2c38 Compare September 10, 2023 22:59
@nartc nartc added the DO NOT MERGE Do not merge this PR for any reason label Sep 10, 2023
Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to run pnpm i (if haven't) and run pnx simple-git-hooks to init the hooks. There's a pre-commit hook which runs pretty-quick. I spotted a couple of formatting issues

libs/ngxtension/assert-injector/src/index.ts Show resolved Hide resolved
libs/ngxtension/computed-from/src/computed-from.spec.ts Outdated Show resolved Hide resolved
libs/ngxtension/computed-from/src/computed-from.spec.ts Outdated Show resolved Hide resolved
@eneajaho eneajaho changed the title [wip] feat(computed-from): added computed from feat(computed-from): added computed from Sep 11, 2023
@eneajaho eneajaho requested a review from nartc September 11, 2023 14:34
@eneajaho eneajaho merged commit 32b8316 into main Sep 11, 2023
6 checks passed
@eneajaho eneajaho deleted the feat/computed-from-wip branch September 11, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR for any reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] add computedFrom
2 participants