Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: Dispose of ImageBitmap data when possible #34

Closed
gkjohnson opened this issue Mar 30, 2020 · 0 comments · Fixed by #36
Closed

Cache: Dispose of ImageBitmap data when possible #34

gkjohnson opened this issue Mar 30, 2020 · 0 comments · Fixed by #36

Comments

@gkjohnson
Copy link
Contributor

ImageBitmap includes a close function which allows for immediately discarding of image data when it's no longer needed. We could at least call this on disposeTile if not sooner. It should not be called earlier than first render, though, because it cannot be closed before upload to GPU. If the renderer is being used in multiple WebGLRenderers then it shouldn't ever be discarded until the tile is disposed.

@gkjohnson gkjohnson added this to the Initial Release milestone Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant