Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for duty control of drive motors #171

Closed
Achllle opened this issue Oct 9, 2023 · 4 comments
Closed

Add support for duty control of drive motors #171

Achllle opened this issue Oct 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Achllle
Copy link
Collaborator

Achllle commented Oct 9, 2023

This is easy to add in code but we'll need to modify the command message or create a new one.

Right now the rover only supports velocity control. In some cases it could be better to command duty cycle to the drive motors as opposed to doing closed loop velocity control. This would likely mean less stress on the rover while driving, even though the motions are not as 'accurate' in some sense.

@Achllle Achllle added the enhancement New feature or request label Oct 9, 2023
@Achllle
Copy link
Collaborator Author

Achllle commented Nov 6, 2023

I changed my mind on this - using duty cycle just lowers speed, so you end up with less accurate speed control. The actual fix would be to change the ramping behavior of the speed control by changing acceleration settings.

@Achllle Achllle changed the title Add support for duty control of drive motors Set lower default acceleration for drive motors Nov 6, 2023
@ericjunkins
Copy link
Collaborator

I would make the case that during manual drive with a controller you might prefer open loop instead of closed loop speed control, and that closed loop is really only beneficial for autonomous functionality

@Achllle
Copy link
Collaborator Author

Achllle commented Nov 6, 2023

True, true - I'll undo that change.

@Achllle Achllle changed the title Set lower default acceleration for drive motors Add support for duty control of drive motors Nov 6, 2023
@Achllle
Copy link
Collaborator Author

Achllle commented Mar 30, 2024

completed with #178

@Achllle Achllle closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants