Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCB-323: Fix schema formation rule for lidvid_reference (Part II) #270

Closed
rchenatjpl opened this issue Jul 21, 2020 · 5 comments
Closed

CCB-323: Fix schema formation rule for lidvid_reference (Part II) #270

rchenatjpl opened this issue Jul 21, 2020 · 5 comments
Assignees
@jshughes
Labels
B11.1 bug Something isn't working Epic pending-scr Approved SCR queued for implementation wontfix This will not be worked on

Comments

@rchenatjpl
Copy link

I've successfully ingested a few context products whose LIDs include +. They did validate correctly. Now when one is listed in a collection.xml's csv, validate complains.

I'm going to assume + is a legal character. If that's wrong, please let me know ASAP, and I'll have a lot to fix.
Archive.zip
@msbentley
Copy link

I always understood pluses to be illegal in LIDs. According to the standards reference (6D.2) the only valid characters are:

  • lower case letters
  • digits
  • dash
  • period
  • underscore

@jordanpadams
Copy link
Member

From SR:

Screen Shot 2020-07-22 at 9 32 48 AM

@jordanpadams jordanpadams changed the title content validation of LID does not match validation of LID Update LID validation to meet PDS4 SR Requirements Jul 22, 2020
@jordanpadams jordanpadams changed the title Update LID validation to meet PDS4 SR Requirements Update LID validation to meet latest PDS4 SR Requirements Jul 22, 2020
@jordanpadams
Copy link
Member

tabled for now. to be fixed by SCR. TBD SCR information to be attached.

@jordanpadams
Copy link
Member

Now being tracked by https://pds-jira.jpl.nasa.gov/browse/CCB-323

@jordanpadams jordanpadams changed the title Update LID validation to meet latest PDS4 SR Requirements CCB-323: Fix schema formation rule for lidvid_reference (Part II) Dec 17, 2020
@jordanpadams jordanpadams transferred this issue from NASA-PDS/validate Dec 17, 2020
@jordanpadams jordanpadams added B11.1 bug Something isn't working pending-scr Approved SCR queued for implementation Epic wontfix This will not be worked on labels Dec 17, 2020
@jordanpadams
Copy link
Member

Per comment from @rchenatjpl on the SCR, this appears to have been fixed as part of other bug fixes in 1E00+

@jordanpadams jordanpadams mentioned this issue Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshughes jshughes

Labels
B11.1 bug Something isn't working Epic pending-scr Approved SCR queued for implementation wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@msbentley @jshughes @jordanpadams @rchenatjpl