Fix #113, Use size_t for size parameters and variables
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -340,7 +340,7 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| void DS_FileWriteData(int32 FileIndex, const void *FileData, uint32 DataLength) | |||
| void DS_FileWriteData(int32 FileIndex, const void *FileData, size_t DataLength) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -639,11 +639,11 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| bool DS_TableEntryUnused(const void *TableEntry, int32 BufferSize) | |||
| bool DS_TableEntryUnused(const void *TableEntry, size_t BufferSize) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
thnkslprpt
force-pushed
the
fix-113-use-size-t-for-size-parameters-and-variables
branch
from
55a463d
to
e4be2f2
Compare
thnkslprpt
force-pushed
the
fix-113-use-size-t-for-size-parameters-and-variables
branch
from
e4be2f2
to
59fa75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
size_tfor size parameters/variables #113size_ttypedef.DS_TableEntryUnused()parameterBufferSizewas signed previous to this change, but it is actually used in DS withsize_ttypes being passed in to that parameteriinDS_TableEntryUnused()to unsigned for clarity/defensivenessNote: there is a signed/unsigned comparison in
DS_FileWriteData(), but I know there are many other cases of this in cFS currently.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change to overall behavior.
Code is more compliant with relevant coding standards (JPL, MISRA etc. which all prefer the more expressive typedefs where possible).
Contributor Info
Avi Weiss @thnkslprpt