Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Improvement #8

Open
fxnoob opened this issue Oct 16, 2019 · 4 comments
Open

Performance Improvement #8

fxnoob opened this issue Oct 16, 2019 · 4 comments

Comments

@fxnoob
Copy link

fxnoob commented Oct 16, 2019

Instead of loading acronym.json on each page load, that should be placed in background script
or that could be made offline.
and acronym dictionary should be formed once.

@fxnoob
Copy link
Author

fxnoob commented Oct 16, 2019

Hi @joelmalissa , I would like to submit a PR if that seems ok.

@joelmalissa
Copy link
Contributor

joelmalissa commented Oct 17, 2019 via email

@fxnoob
Copy link
Author

fxnoob commented Oct 19, 2019

Hi @joelmalissa ,

How would you code this to use the list in a background script?

I would introduce message passing between background script and content script eg. Message Passing

I will be submitting a PR later today. Half way through already.

@fxnoob fxnoob mentioned this issue Oct 19, 2019
@fxnoob
Copy link
Author

fxnoob commented Oct 19, 2019

Hi @joelmalissa , have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants