Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa-next] Avoid FOUC #29

Closed
frankiefu opened this issue Nov 5, 2016 · 1 comment
Closed

[nasa-next] Avoid FOUC #29

frankiefu opened this issue Nov 5, 2016 · 1 comment

Comments

@frankiefu
Copy link
Collaborator

frankiefu commented Nov 5, 2016

We should try to minimize FOUC as much as possible. Currently when you reload https://polymer-nasa.appspot.com you will see the footer shows up at the top right below the tabs and then immediately disappears after the list is rendered. To avoid FOUC one way we could do is to make <code-nasa-app> has min-height: 100vh so the footer is always at the bottom.

@keanulee
Copy link
Collaborator

keanulee commented Nov 7, 2016

There's no guarantee that the content is at least 100vh (e.g. the share page is really short)

Put min-height: 100vh on -app and -projects/-share/-guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants