-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify main.py and survey.py #42
Comments
How do you feel about a class representing the survey? Right now, you calculate the times and such in main.py, which is currently factored out into the Survey class. |
I am OK with exposure time being part of the Mission class. I want the time step to be part of the command line arguments, though. Same for the HEALPix resolution. Also I now am drawing a distinction between the HEALPix grid that is used for spatial calculations and the tessellation grid that specifies the allowed pointings of the telescope. |
Maybe you also want to support one of the tiling files as an optional option? This would help bring it into alignment. |
Why do we need to support providing the list of tiles as a file? Generating the tile grid is nearly instantaneous. |
But presumably we want a tile file like ZTF's (and UVEX) for the facilities that will pin the grid? Even if the grid is reproducible, people will want the file.. |
This is a good point. We can use argparse's |
Fixed by #44 |
It seems like there are very few important differences between these two files. The only differences that I can see are minor variations in the command line arguments.
The text was updated successfully, but these errors were encountered: