Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Return Value of fseek #85

Open
ArielSAdamsNASA opened this issue Sep 23, 2021 · 0 comments · May be fixed by #123
Open

Check Return Value of fseek #85

ArielSAdamsNASA opened this issue Sep 23, 2021 · 0 comments · May be fixed by #123

Comments

@ArielSAdamsNASA
Copy link

ArielSAdamsNASA commented Sep 23, 2021 •
edited

Describe the bug
The return value of fseek is not checked which may cause an unexpected failure.

Expected behavior
Check the return value for fseek in elf2cfetbl.c.

Code snips

elf2cfetbl/elf2cfetbl.c

Line 1744 in 10f55fb

fseek(SrcFileDesc, SeekOffset, SEEK_SET);

elf2cfetbl/elf2cfetbl.c

Line 1925 in 10f55fb

fseek(SrcFileDesc, SeekOffset, SEEK_SET);

elf2cfetbl/elf2cfetbl.c

Line 2278 in 10f55fb

fseek(SrcFileDesc, SeekOffset, SEEK_SET);

elf2cfetbl/elf2cfetbl.c

Line 2432 in 10f55fb

fseek(SrcFileDesc, SeekOffset, SEEK_SET);

Additional context
Identified by Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Possible solution:

                Status = fseek(SrcFileDesc, SeekOffset, SEEK_SET);
                if (Status != 0)
                {
                    printf("Error locating Section Header #%d in file '%s'\n", SectionIndex, SrcFilename);
                    return FAILED;
                }
                else 
                {
                    fseek(SrcFileDesc, SeekOffset, SEEK_SET);
                }

Reporter Info
Ariel Adams, ASRC Federal
ArielSAdamsNASA pushed a commit that referenced this issue Oct 12, 2021
@arielswalker
Fix #85, Check Return Value of fseek
0a93f98
thnkslprpt added a commit to thnkslprpt/elf2cfetbl that referenced this issue Nov 11, 2022
@thnkslprpt
Fix nasa#85, Add checks for all return values from fseek()
4bdd9b7
@thnkslprpt thnkslprpt linked a pull request Nov 11, 2022 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #85, Add checks for all return values from fseek() thnkslprpt/elf2cfetbl
1 participant
@ArielSAdamsNASA