Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References to time members in CFE_FS_Header_t should be converted to CFE_TIME_SysTime_t #133

Open
thnkslprpt opened this issue Apr 2, 2023 · 0 comments · May be fixed by #134
Open

References to time members in CFE_FS_Header_t should be converted to CFE_TIME_SysTime_t #133

thnkslprpt opened this issue Apr 2, 2023 · 0 comments · May be fixed by #134

Comments

@thnkslprpt
Copy link
Contributor

Describe the bug
cFE PR nasa/cFE#2246 converts all remaining seconds/subseconds time struct members to use CFE_TIME_SysTime_t that were not already doing so.
elf2cfetbl requires some updates as it references one of them directly (for cFE FS) in a few locations.

Code snips

elf2cfetbl/elf2cfetbl.c

Lines 2528 to 2536 in 46b29f8

if (EnableTimeTagInHeader)
{
FileHeader.TimeSeconds = SrcFileTimeInScEpoch;
FileHeader.TimeSubSeconds = 0;
}
else
{
FileHeader.TimeSeconds = 0;
FileHeader.TimeSubSeconds = 0;

Expected behavior
Needs to be updated to reference the time members through the CFE_TIME_SysTime_t sub-struct.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/elf2cfetbl that referenced this issue Apr 2, 2023
@thnkslprpt
Fix nasa#133, Update references to CFE_FS_Header_t time members
d097ed8
@thnkslprpt thnkslprpt linked a pull request Apr 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #133, Update references to CFE_FS_Header_t time members thnkslprpt/elf2cfetbl
1 participant
@thnkslprpt