Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(F841) Local variable name is assigned to but never used #130

Closed
ThibFrgsGmz opened this issue Apr 22, 2023 · 1 comment · Fixed by #136
Closed

(F841) Local variable name is assigned to but never used #130

ThibFrgsGmz opened this issue Apr 22, 2023 · 1 comment · Fixed by #136
Labels
bug Something isn't working

Comments

@ThibFrgsGmz
Copy link
Contributor

F´ Version devel
Affected Component string_util.py

Problem Description

Ruff linter spotted one issue in:

https://github.com/fprime-community/fprime-tools/blob/58e28dfa4a1c93e55aff533747def2b5386aa40f/src/fprime/util/string_util.py#L95

src/fprime/util/string_util.py:95:26: F841 [*] Local variable `e` is assigned to but never used

According to Flake 8: "A local variable in your function was defined but is not being used. This local variable should be removed."

Ref: https://www.flake8rules.com/rules/F841.html

Expected Behavior

The variable should be used or be removed.

PS: can be tagged as Good First Issue

@ThibFrgsGmz ThibFrgsGmz added the bug Something isn't working label Apr 22, 2023
@stepanzubkov
Copy link
Contributor

Hi, can I take this issue?

@thomas-bc thomas-bc linked a pull request May 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants