Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFcsv_reader leaving unclosed file #75

Closed
sapols opened this issue Apr 5, 2022 · 1 comment
Closed

SFcsv_reader leaving unclosed file #75

sapols opened this issue Apr 5, 2022 · 1 comment

Comments

@sapols
Copy link
Contributor

sapols commented Apr 5, 2022

To avoid rerunning the ModelFlythrough function multiple times, I've been using the SFcsv_reader to read in the CSV file that gets output by ModelFlythrough. It seems that file is not getting closed after opening it. I get the warning:

/shared-libs/python3.7/py-core/lib/python3.7/site-packages/ipykernel_launcher.py:8: ResourceWarning: unclosed file <_io.TextIOWrapper name='/root/work/Output/ModelFlythrough/OpenGGCMFlythrough.csv' mode='r' encoding='UTF-8'>

I haven't looked at your other readers, but if this is happening with the CSV reader, it's likely happening with other readers too.
@rebeccaringuette
Copy link
Contributor

Fixed in PR#80. Recommend closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sapols @rebeccaringuette @darrendezeeuw