Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the annotation text is upside down. #79

Closed
servetg opened this issue Feb 13, 2017 · 3 comments
Closed

Sometimes the annotation text is upside down. #79

servetg opened this issue Feb 13, 2017 · 3 comments
Labels
Milestone

Comments

@servetg
Copy link
Contributor

servetg commented Feb 13, 2017

That's because the loading of texture coordinate matrix has been omitted.
A solution would be:

  1. texCoordMatrix initialization in Annotation's constructor
    line 115:
    // Internal use only. Intentionally not documented.
    this.texCoordMatrix = Matrix.fromIdentity();

  2. texCoordMatrix loading in Annotation.prototype.doDrawOrderedAnnotation, after program.loadTextureEnabled(gl, textureBound);
    line 513:
    this.texCoordMatrix.setToIdentity();
    this.texCoordMatrix.multiplyByTextureTransform(this.labelTexture);
    program.loadTextureMatrix(gl, this.texCoordMatrix);

@servetg servetg added the bug label Feb 13, 2017
@pdavidc
Copy link
Contributor

pdavidc commented Feb 14, 2017

Servet, Thanks for investigating this issue. The team has reviewed your proposal, and would like to get this fix in the repository. Would you please put together a fix and commit it to the develop branch?

@pdavidc pdavidc modified the milestone: v0.1.0 Feb 17, 2017
@servetg
Copy link
Contributor Author

servetg commented Feb 20, 2017

Dave, I've made a pull request containing a fix for this bug.

@pdavidc
Copy link
Contributor

pdavidc commented Feb 21, 2017

Fix is in pull request #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants