Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Clear search #87

Open
jef opened this issue Oct 11, 2021 · 3 comments
Open

[Feature]: Clear search #87

jef opened this issue Oct 11, 2021 · 3 comments

Comments

@jef
Copy link

jef commented Oct 11, 2021

Just a little quality of life enhancement would be to clear the search without having to select all and delete. This would either replace the current search icon or be next to it. As I see it, search button doesn't have much functionality given it automatically searches.

@Nasicus
Copy link
Owner

Nasicus commented Oct 17, 2021

The search button mainly show that this is a "search field".
For me it would be ok that, if you click the search button all text is automatically highlighted in the search field and then you can simply press the "DEL" key to delete it.

@R3ality
Copy link

R3ality commented Oct 17, 2021

Alternatively I would suggest adding an on-click action to the field itself. If the user clicks on the search field while something has already been typed into it, the entered text should be auto-selected. This way it gets replaced once user starts typing.

This would certainly simplify the use case where users are checking items in-game and then searching for them in the Holy Grail (to see if they have already been found before). Especially if checking multiple items subsequently.

@jef
Copy link
Author

jef commented Oct 19, 2021

Seems fine to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants