Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally allow touching but nonoverlapping polygons in calculate_disjoint_polygon_set #269

Closed
phargogh opened this issue Jul 20, 2022 · 1 comment · Fixed by #287
Closed

Optionally allow touching but nonoverlapping polygons in calculate_disjoint_polygon_set #269

phargogh opened this issue Jul 20, 2022 · 1 comment · Fixed by #287
Assignees
@phargogh
Labels
enhancement New feature or request
Milestone
2.3.5

Comments

@phargogh
Copy link
Member

In working on Urban Nature Access, we had a case where we had a large cluster of polygons with boundaries that touched but whose interiors were all distinct. Using the current implementation of calculate_disjoint_polygon_set, there were 8 groupings of polygons. I propose including an optional flag in calculate_disjoint_polygon_set to not consider touching polygons as intersecting.

The scope of work here would be a couple hours to implement, test and PR in.
@phargogh phargogh added the enhancement New feature or request label Jul 20, 2022
@phargogh phargogh self-assigned this Jul 20, 2022
@davemfish
Copy link
Contributor

👍 This almost sounds like a bugfix

@phargogh phargogh mentioned this issue Aug 12, 2022
Merged
@phargogh phargogh added this to the 2.3.5 milestone Dec 2, 2022
@phargogh phargogh changed the title Proposal: optionally allow touching but nonoverlapping polygons in calculate_disjoint_polygon_set Optionally allow touching but nonoverlapping polygons in calculate_disjoint_polygon_set Dec 9, 2022
@phargogh phargogh mentioned this issue Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.3.5
Development

Successfully merging a pull request may close this issue.

Feature/269 allow touching nonoverlapping polygons in disjoint polygon set phargogh/pygeoprocessing
2 participants
@davemfish @phargogh