Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure numerically-close float function parameters are treated as identical #81

Open
phargogh opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@phargogh
Copy link
Member

We sometimes have floating-point parameters such as bounding boxes or coordinate pairs that are represented by floating-point objects. If these are interpreted as floats by taskgraph, it's possible that we might be recomputing a task based on parameters that might differ, but only differ by a numerically insignificant quantity.

If this is the case, we should only recompute if the float is significantly different from the old float, but offer a flag to do as-is comparison.

In the case of a parameter like a bounding box, it would also be nice for the comparison to happen on a per-element basis.

@phargogh phargogh added the enhancement New feature or request label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant