Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website Dockerfile to produce a production-ready image #7

Closed
natearn opened this issue Jul 6, 2020 · 1 comment · Fixed by #8
Closed

Update website Dockerfile to produce a production-ready image #7

natearn opened this issue Jul 6, 2020 · 1 comment · Fixed by #8
Labels
enhancement New feature or request

Comments

@natearn
Copy link
Owner

natearn commented Jul 6, 2020

The primary role of these Dockerfiles is to build images for production. Ideally, these images can also be used as-is for development, but I don't expect that to necessarily be satisfiable.

Improvements:

  • Replace the server with something that claims to be intended for running in a production environment.
  • Run the server as an unprivileged user (not root).
  • Separate dependencies from source code to speed up builds.

Considerations:

  • A server that can be configured to use hot-reloading on source file changes.
  • A server that can be configured to produce logs that are valuable for development and debugging.
@natearn natearn added the enhancement New feature or request label Jul 6, 2020
@natearn natearn added this to To do in Deploy a 12 Factor App via automation Jul 6, 2020
@natearn
Copy link
Owner Author

natearn commented Jul 6, 2020

The current website image is actually very frustrating to work with in dev also. I'm going to make this a priority.

@natearn natearn moved this from To do to In progress in Deploy a 12 Factor App Jul 6, 2020
@natearn natearn closed this as completed in #8 Jul 7, 2020
Deploy a 12 Factor App automation moved this from In progress to Merged Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant