Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: panic when selecting next line down (0 matches) #56

Closed
ezradiniz opened this issue Dec 26, 2023 · 0 comments · Fixed by #57
Closed

bug: panic when selecting next line down (0 matches) #56

ezradiniz opened this issue Dec 26, 2023 · 0 comments · Fixed by #57

Comments

@ezradiniz
Copy link
Contributor

How to reproduce?

  1. git ls-files | zf
  2. type anything that doesn't match (ex: asdfasdfasdf)
  3. Select next line down (ex: ctrl-n)

Output:

> asdfasdfthread 60328 panic: integer overflow                                                                                                                            0/25
/home/ezra/dev/zf/src/ui.zig:552:39: 0x2532b4 in lineDown (zf)
   if (state.selected < visible_rows - 1) {
                                     ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid integer overflow when selecting line down ezradiniz/zf
1 participant
@ezradiniz