Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question]don't the atomic package need to call fsync? #5

Closed
lufia opened this issue Apr 23, 2019 · 1 comment · Fixed by #10
Closed

[question]don't the atomic package need to call fsync? #5

lufia opened this issue Apr 23, 2019 · 1 comment · Fixed by #10

Comments

@lufia
Copy link

lufia commented Apr 23, 2019

Hi, I'm reading this package.

Modern OSes probably has dirty buffer, so I think WriteFile needs to flush the buffer with fsync or fdatasync.
Windows might need to replace these syscalls with FlushFileBuffers.

@Al2Klimov
Copy link
Contributor

Sure. See https://stackoverflow.com/a/15348491 . Stumbled over this as well, wondering why @natefinch didn’t have it already. But nevermind, I've opened PR #14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants