You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking into this it seems that the exit status returned from a child process is not handled gracefully in some instances.
Ideally the exit status should be using the macros defined in sys/wait.h but it is only used sparingly across drmaa.c. Notably the macro WIFEXITED is used but not WIFSIGNALED or WTERMSIG. For example, instead of WIFSIGNALED there is an operation that may or may not be the same as the macro necessary for that particular architecture. Is there a reason why these macros were not used?
This is related to Issue #26. After removing the hardcoded exit status manipulation with macros, I suddenly went from jobs reporting "unknown signal?!" to "wasTerminated" which was far more informative in terms of tracking down our issues (and ultimately solved our problem).
The text was updated successfully, but these errors were encountered:
Looking into this it seems that the exit status returned from a child process is not handled gracefully in some instances.
Ideally the exit status should be using the macros defined in
sys/wait.h
but it is only used sparingly acrossdrmaa.c
. Notably the macroWIFEXITED
is used but notWIFSIGNALED
orWTERMSIG
. For example, instead ofWIFSIGNALED
there is an operation that may or may not be the same as the macro necessary for that particular architecture. Is there a reason why these macros were not used?This is related to Issue #26. After removing the hardcoded exit status manipulation with macros, I suddenly went from jobs reporting "unknown signal?!" to "wasTerminated" which was far more informative in terms of tracking down our issues (and ultimately solved our problem).
The text was updated successfully, but these errors were encountered: