Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unable to parse response as XML" exception being thrown when there are no errors #58

Closed
justincy opened this issue Sep 28, 2012 · 0 comments · Fixed by #59
Closed

"Unable to parse response as XML" exception being thrown when there are no errors #58

justincy opened this issue Sep 28, 2012 · 0 comments · Fixed by #59

Comments

@justincy
Copy link
Contributor

This happens when the SimpleXMLElement returned by simplexml_load_string() is empty. Somehow adding ! in front of it converts to a boolean false. This can be fixed by checking for $parsed === false.
@justincy justincy mentioned this issue Sep 28, 2012
Merged
nategood pushed a commit that referenced this issue Oct 6, 2012
v0.2.0
00a0cc1 
 - REFACTOR [PR #49](#49) Broke headers out into their own class
 - REFACTOR [PR #54](#54) Added more specific Exceptions
 - FIX [PR #58](#58) Fixes throwing an error on an empty xml response
 - FEATURE [PR #57](#57) Adds support for digest authentication
@nategood nategood closed this as completed Oct 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XML parsing exception from being thrown incorrectly justincy/httpful
2 participants
@nategood @justincy