Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log #82

Merged
merged 6 commits into from
Feb 25, 2023
Merged

feat: add log #82

merged 6 commits into from
Feb 25, 2023

Conversation

ulken
Copy link
Collaborator

@ulken ulken commented Feb 23, 2023

No docs, nor examples, yet, but working implementation to play with.

Screenshot 2023-02-24 at 00 51 39

Closes #71.

@ulken ulken self-assigned this Feb 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: 165a1b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/prompts/src/index.ts Show resolved Hide resolved
packages/prompts/src/index.ts Show resolved Hide resolved
Copy link
Collaborator

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few suggestions but overall really pleased with this API and implementation!

packages/prompts/src/index.ts Outdated Show resolved Hide resolved
packages/prompts/src/index.ts Outdated Show resolved Hide resolved
@ulken ulken marked this pull request as ready for review February 25, 2023 00:04
@ulken
Copy link
Collaborator Author

ulken commented Feb 25, 2023

Addressed your feedback. How do you feel about documentation and/or examples for this?

Copy link
Collaborator

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing addition, thank you so much!

Re: docs/examples—I'm hoping to knock out some docs this weekend, so I can tackle this.

@natemoo-re natemoo-re merged commit a79733e into main Feb 25, 2023
@natemoo-re natemoo-re deleted the feat/log branch February 25, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Allow arbitraty text as part of the chain
2 participants