Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Issues in 'run_20_newgroups.py' when load_embed = False #55

Open
dbl001 opened this issue Jun 23, 2019 · 1 comment
Open

Issues in 'run_20_newgroups.py' when load_embed = False #55

dbl001 opened this issue Jun 23, 2019 · 1 comment

Comments

@dbl001
Copy link
Collaborator

dbl001 commented Jun 23, 2019

  1. vocab_size does not get set with load_embed = False
    E.g.
vocab_size = embed_matrix.shape[0] 
  1. utils.load_preprocessed_data() returns 6 parameters (not 7) when load_embed = False
(idx_to_word, word_to_idx, freqs, pivot_ids,
 target_ids, doc_ids, **_embed_matrix_**) = utils.load_preprocessed_data(data_path, load_embed_matrix=load_embeds)

@dbl001
Copy link
Collaborator Author

dbl001 commented Jun 24, 2019

Perhaps:

vocab_size = embed_matrix.shape[0] if load_embeds else len(idx_to_word)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant