Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should walk instead be a pipeline? #28

Closed
nateraw opened this issue Sep 12, 2022 · 2 comments
Closed

Should walk instead be a pipeline? #28

nateraw opened this issue Sep 12, 2022 · 2 comments
Labels
discussion To discuss an issue/feature enhancement New feature or request

Comments

@nateraw
Copy link
Owner

nateraw commented Sep 12, 2022

When I first made this repo, it was basically just a script, which is why the stable_diffusion_walk.py file is the way it is. However, as the ideas and features here grow, it may be nice to structure things a bit better (especially if we add new workflows like #27 and #26 ).

We could have logic of walk be the __call__ function of a new pipeline, StableDiffusionForVideosPipeline or whatever. This would be a self-contained pipeline object - essentially building on top of the existing pipeline file. Then, as we write up the logic for the above additional workflows, they can become their own self-contained pipelines as well.

Anybody have any thoughts here? This would be a pretty big restructure with breaking API changes, but would be a bit more "professional" and less hacky. But maybe its fine this remains hacky. idk😅

@nateraw nateraw added enhancement New feature or request discussion To discuss an issue/feature labels Sep 12, 2022
@nateraw
Copy link
Owner Author

nateraw commented Sep 12, 2022

I realize how gross it is to have a module in a python package initialize a torch model in the global scope haha.

@nateraw
Copy link
Owner Author

nateraw commented Oct 10, 2022

its a pipeline now

@nateraw nateraw closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion To discuss an issue/feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant