Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is -[FHSTwitterEngineController dealloc] missing a [super dealloc] #1

Closed
mrose17 opened this issue Dec 28, 2012 · 8 comments
Closed

Comments

@mrose17
Copy link

mrose17 commented Dec 28, 2012

xcode 4.5.2 thinks so!

best,

/mtr

ps: thanks for the nice package, i hope to be using it in an application that should be going into alpha soon!

pps: yes, i did add all the -fno-obc-arc entries, otherwise, no compilation joy!

@natesymer
Copy link
Owner

Expect a new commit in the near future, The twitter controller is a tad hacky... But the lack of -[super dealloc] is expected in ARC.

On Dec 28, 2012, at 2:46 PM, mrose17 notifications@github.com wrote:

xcode 4.5.2 thinks so!

best,

/mtr

ps: thanks for the nice package, i hope to be using it in an application that should be going into alpha soon!

pps: yes, i did add all the -fno-obc-arc entries, otherwise, no compilation joy!


Reply to this email directly or view it on GitHub.

@mrose17
Copy link
Author

mrose17 commented Dec 28, 2012

many thanks! ...although in fairness, one could comment that the whole "authenticate an app to twitter/facebook/etc." is a bit of a kabuki dance...

@mrose17 mrose17 closed this as completed Dec 28, 2012
@natesymer
Copy link
Owner

Indeed, there are many issues with how modern authentication is handled. Why can't everyone use xAuth?

On Dec 28, 2012, at 3:00 PM, mrose17 notifications@github.com wrote:

many thanks! ...although in fairness, one could comment that the whole "authenticate an app to twitter/facebook/etc." is a bit of a kabuki dance...


Reply to this email directly or view it on GitHub.

@mrose17
Copy link
Author

mrose17 commented Dec 29, 2012

i see the value in not giving the actual password to the application. it just seems that the actual implementation of oauth to do this is somewhat lacking...

@natesymer
Copy link
Owner

Twitter could just simplify their login page, canning a bunch of unnecessary JavaScript. I'm not too sure on the details of the login redirection system, but perhaps the access token could be passed in a "success" URL. The new login flow could be accessed by a parameter in the request token URL...

@mrose17
Copy link
Author

mrose17 commented Dec 31, 2012

true. although i've often wondered why we don't just say "you have 30 seconds to go to a web browser, login to your twitter account, click on 'one-time pin' and then enter the six digit pin into the app."

@natesymer
Copy link
Owner

It's just too much of a pain. It takes too long. Users want quick login. I guess that's why xAuth exists, but really...

On Dec 30, 2012, at 10:07 PM, mrose17 notifications@github.com wrote:

true. although i've often wondered why we don't just say "you have 30 seconds to go to a web browser, login to your twitter account, click on 'one-time pin' and then enter the six digit pin into the app."


Reply to this email directly or view it on GitHub.

@mrose17
Copy link
Author

mrose17 commented Dec 31, 2012

good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants